Fix AtomicSharedPtr for C++20 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyohannes
requested review from
g-easy,
jmacd,
maxgolov,
reyang,
rnburn and
tigrannajaryan
as code owners
maxgolov
approved these changes
Jun 15, 2020
g-easy
reviewed
Jun 16, 2020
| @@ -20,6 +20,16 @@ if [[ "$1" == "cmake.test" ]]; then | |||
| make | |||
| make test | |||
| exit 0 | |||
| elif [[ "$1" == "cmake.c++20.test" ]]; then | |||
There was a problem hiding this comment.
Please mention this in the README.
g-easy
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #105. Our code was relying on a template specialization of
std::atomicforstd::shared_ptr<T>, which isn't provided byg++.Instead we now rely on specializations of
std::atomic_storeandstd::atomic_loadfor everything except gcc 4.8.To guard against similar issues in future, I added a C++20 test to the shiny new GHA CI.