Add log level for internal log of sdk #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
+ Coverage 93.26% 93.28% +0.02%
==========================================
Files 173 174 +1
Lines 6362 6391 +29
==========================================
+ Hits 5933 5961 +28
- Misses 429 430 +1
|
owent
force-pushed
the
add_internal_log_level
branch
2 times, most recently
from
278707f
to
60826d9
Compare
lalitb
reviewed
Dec 22, 2021
owent
force-pushed
the
add_internal_log_level
branch
from
6bf6668
to
4f5187e
Compare
lalitb
reviewed
Dec 23, 2021
| @@ -16,7 +17,7 @@ | |||
| #define OTEL_INTERNAL_LOG_LEVEL_DEBUG 3 // to be disabled in release | |||
|
|
|||
| #ifndef OTEL_INTERNAL_LOG_LEVEL | |||
| # define OTEL_INTERNAL_LOG_LEVEL OTEL_INTERNAL_LOG_LEVEL_WARN // ERROR and WARN | |||
| # define OTEL_INTERNAL_LOG_LEVEL OTEL_INTERNAL_LOG_LEVEL_DEBUG // ERROR and WARN | |||
There was a problem hiding this comment.
nit - change the comment?
done
|
@owent - this looks good to merge. Would you rebase it to the main branch? Thanks. |
+ Fix document for internal log of sdk + Fix crash problem when any provider is destroyed after internal log handle. Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
owent
force-pushed
the
add_internal_log_level
branch
from
9cb7f0a
to
e73df79
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: owentou owentou@tencent.com
Fixes #1138
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes