ZipkinExporter shutdown #1153
Merged
ZipkinExporter shutdown #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1153 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 165 165
Lines 6229 6229
=======================================
Hits 5817 5817
Misses 412 412 |
lalitb
approved these changes
Dec 20, 2021
ThomsonTan
approved these changes
Dec 20, 2021
lalitb
reviewed
Dec 20, 2021
| @@ -98,6 +98,12 @@ void ZipkinExporter::InitializeLocalEndpoint() | |||
| local_end_point_["port"] = url_parser_.port_; | |||
| } | |||
|
|
|||
| bool ZipkinExporter::Shutdown(std::chrono::microseconds timeout) noexcept | |||
| { | |||
| isShutdown_ = true; | |||
There was a problem hiding this comment.
Not related to PR, but probably we need to discuss if this should be an atomic operation to protect against Shutdown() and Export() called from separate threads. While specs don't allow Export() to be called concurrently ( https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#exportbatch ), it doesn't talk about Export() and Shutdown().
This is valid to all exporters, and not blocking this PR.
There was a problem hiding this comment.
Agree it should be protected somehow.
This was referenced Jan 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ZipkinExporter shutdown
Changes
ZipkinExporter shutdown should set shutdown before return
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes