Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sampler header file #118

Merged
merged 31 commits into from
Jun 23, 2020
Merged
Changes from 23 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 91 additions & 0 deletions sdk/include/opentelemetry/sdk/trace/sampler.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
#pragma once

#include "opentelemetry/common/attribute_value.h"
#include "opentelemetry/nostd/span.h"
#include "opentelemetry/nostd/string_view.h"
#include "opentelemetry/sdk/common/atomic_shared_ptr.h"
#include "opentelemetry/trace/span.h"
#include "opentelemetry/trace/trace_id.h"
#include "opentelemetry/trace/tracer.h"
#include "opentelemetry/version.h"
ziqizh marked this conversation as resolved.
Show resolved Hide resolved

#include <map>
#include <memory>
#include <string>

OPENTELEMETRY_BEGIN_NAMESPACE
namespace sdk
{
namespace trace
{
namespace trace_api = opentelemetry::trace;
/**
* NOT_RECORD - IsRecording() == false,
* span will not be recorded and all events and attributes will be dropped.
* RECORD - IsRecording() == true, but Sampled flag MUST NOT be set.
* RECORD_AND_SAMPLED - IsRecording() == true AND Sampled flag` MUST be set.
*/
enum class Decision
{
NOT_RECORD,
ziqizh marked this conversation as resolved.
Show resolved Hide resolved
RECORD,
RECORD_AND_SAMPLE
};

/**
* A placeholder for common::AttributeKeyValue
* A key/value pair that can be used to set attributes.
*/
struct AttributeKeyValue {
nostd::string_view key;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storing a string_view has some pitfalls - string_view is essentially a pointer to an underlying string, so it relies on the underlying string value to outlive the string_view's lifetime. If "key" isn't too large, I recommend just storing it as a string.

common::AttributeValue value;
};

struct SamplingResult
{
Decision decision;
// TODO: Change AttributeKeyValue to common::AttributeKeyValue
std::unique_ptr<nostd::span<AttributeKeyValue>> attributes;
ziqizh marked this conversation as resolved.
Show resolved Hide resolved
};

class Sampler
pyohannes marked this conversation as resolved.
Show resolved Hide resolved
{
public:
// Placeholder
class SpanContext
{};
virtual ~Sampler() = default;
/**
* Called during Span creation to make a sampling decision.
*
* @param parent_context TODO: a shared pointer of the SpanContext of a parent Span.
ziqizh marked this conversation as resolved.
Show resolved Hide resolved
* null if this is a root span.
* @param trace_id the TraceId for the new Span. This will be identical to that in
* the parentContext, unless this is a root span.
* @param name the name of the new Span.
* @param spanKind the trace_api::SpanKind of the Span.
* @param attributes // TODO: Change AttributeKeyValue to common::AttributeKeyValue
* list of AttributeValue with their keys.
* @param links TODO: Collection of links that will be associated with the Span to be created.
ziqizh marked this conversation as resolved.
Show resolved Hide resolved
* @return sampling result whether span should be sampled or not.
* @since 0.1.0
*/

virtual SamplingResult ShouldSample(
ziqizh marked this conversation as resolved.
Show resolved Hide resolved
const SpanContext *parent_context,
trace_api::TraceId trace_id,
nostd::string_view name,
trace_api::SpanKind span_kind,
const nostd::span<AttributeKeyValue> &attributes) noexcept = 0;
ziqizh marked this conversation as resolved.
Show resolved Hide resolved

/**
* Returns the sampler name or short description with the configuration.
* This may be displayed on debug pages or in the logs.
*
* @return the description of this Sampler.
*/
virtual std::string GetDescription() const noexcept = 0;
};
} // namespace trace
} // namespace sdk
OPENTELEMETRY_END_NAMESPACE