Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start zPages README #131

Merged
merged 7 commits into from
Jun 30, 2020
Merged

Start zPages README #131

merged 7 commits into from
Jun 30, 2020

Conversation

jajanet
Copy link
Contributor

@jajanet jajanet commented Jun 27, 2020

PR to start the ext subdirectory, which will hold zPages

Also adding an initial README that includes a high-level overview of zPages, links to public design docs (feel free to add your feedback on those too 😄), and TODOs for future content we'd like to have in the README

Pulled file from commit 901103e, which is in our experimental zPages/TraceZ fork

@jajanet jajanet requested a review from a team June 27, 2020 03:13
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 27, 2020

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jun 27, 2020

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          71       71           
  Lines        1724     1724           
=======================================
  Hits         1612     1612           
  Misses        112      112           

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang
Copy link
Member

reyang commented Jun 29, 2020

@jajanet please rebase and we will be ready to merge.

@reyang reyang merged commit f399bf5 into open-telemetry:master Jun 30, 2020
nadiaciobanu pushed a commit to nadiaciobanu/opentelemetry-cpp that referenced this pull request Jul 2, 2020
@jajanet jajanet deleted the zpages-README branch July 15, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants