-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start zPages README #131
Merged
Merged
Start zPages README #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 71 71
Lines 1724 1724
=======================================
Hits 1612 1612
Misses 112 112 |
maxgolov
approved these changes
Jun 29, 2020
reyang
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@jajanet please rebase and we will be ready to merge. |
nadiaciobanu
pushed a commit
to nadiaciobanu/opentelemetry-cpp
that referenced
this pull request
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to start the ext subdirectory, which will hold zPages
Also adding an initial README that includes a high-level overview of zPages, links to public design docs (feel free to add your feedback on those too 😄), and TODOs for future content we'd like to have in the README
Pulled file from commit 901103e, which is in our experimental zPages/TraceZ fork