Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTLP exporter #152

Merged
merged 13 commits into from
Jul 8, 2020
Merged

Conversation

nadiaciobanu
Copy link
Contributor

@nadiaciobanu nadiaciobanu commented Jul 2, 2020

Add an OTLP exporter that exports spans to the OpenTelemetry Collector via gRPC. Note that this requires adding a gRPC dependency to opentelemetry-cpp.

@nadiaciobanu nadiaciobanu requested a review from a team July 2, 2020 23:34
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files          71       71           
  Lines        1754     1754           
=======================================
  Hits         1642     1642           
  Misses        112      112           

Copy link

@IlyaKobelevskiy IlyaKobelevskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

exporters/otlp/otlp_exporter_test.cc Outdated Show resolved Hide resolved
exporters/otlp/otlp_exporter.h Show resolved Hide resolved
exporters/otlp/otlp_exporter.h Show resolved Hide resolved
exporters/otlp/otlp_exporter.h Outdated Show resolved Hide resolved
exporters/otlp/otlp_exporter.cc Outdated Show resolved Hide resolved
WORKSPACE Outdated Show resolved Hide resolved
exporters/otlp/BUILD Outdated Show resolved Hide resolved
exporters/otlp/otlp_exporter.cc Outdated Show resolved Hide resolved
@nadiaciobanu
Copy link
Contributor Author

@pyohannes Please let me know if you have any other comments!

Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I have two more nits, otherwise this is ready to merge.

exporters/otlp/otlp_exporter.cc Outdated Show resolved Hide resolved
exporters/otlp/otlp_exporter.h Outdated Show resolved Hide resolved
@nadiaciobanu
Copy link
Contributor Author

@reyang Ready to merge!

@reyang
Copy link
Member

reyang commented Jul 8, 2020

@nadiaciobanu would you rebase?

@reyang reyang merged commit 0cf5519 into open-telemetry:master Jul 8, 2020
@nadiaciobanu nadiaciobanu deleted the basic-otlp-exporter branch July 23, 2020 22:30
@nadiaciobanu nadiaciobanu changed the title Add basic OTLP exporter Add OTLP exporter Aug 12, 2020
@reyang reyang mentioned this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants