Fix several compiling/linking errors #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1539 +/- ##
=======================================
Coverage 84.57% 84.57%
=======================================
Files 156 156
Lines 4795 4795
=======================================
Hits 4055 4055
Misses 740 740 |
lalitb
approved these changes
Aug 2, 2022
|
@owent Thanks for the fix, can you please rebase it to merge |
Signed-off-by: owentou <owentou@tencent.com>
Done |
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
Signed-off-by: owentou <owentou@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: owentou owentou@tencent.com
Fixes #1538
Changes
es_log_exporter.emplace_back(unique_ptr<HttpSessionData>(...)).OtlpGrpcMetricExporter::ForceFlush,OtlpGrpcMetricExporter::ShutdownandOtlpGrpcMetricExporter::isShutdown.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes