Fix metrics asan and tsan CI #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
- Coverage 83.38% 83.32% -0.06%
==========================================
Files 156 156
Lines 4975 4975
==========================================
- Hits 4148 4145 -3
- Misses 827 830 +3
|
lalitb
reviewed
Aug 11, 2022
| opentelemetry::sdk::metrics::AsyncMetricStorage storage( | ||
| instr_desc, AggregationType::kSum, new DefaultAttributesProcessor(), | ||
| instr_desc, AggregationType::kSum, default_attributes_processor.get(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes metrics asan and tsan CI
Changes
We have false positive on attributes_hashmap_benchmark.cc, this can be removed if we store the lambda in a variable and construct threads with it.
also a raw pointer was used in test, changed to smart pointer.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes