Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badges to README.md #157

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Add badges to README.md #157

merged 2 commits into from
Jul 8, 2020

Conversation

huyan0
Copy link
Member

@huyan0 huyan0 commented Jul 7, 2020

This PR adds status badges for repo license, build status and code coverage to README.md
This is useful for all developers to get a at-a-glance status of the repository.

@huyan0 huyan0 requested a review from a team July 7, 2020 23:09
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 7, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited
Loading

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files          71       71           
  Lines        1754     1754           
=======================================
  Hits         1642     1642           
  Misses        112      112

@reyang
Copy link
Member

reyang commented Jul 7, 2020

The visual seems inconsistent, and there is a line break which we want to remove:

image

@reyang
Copy link
Member

reyang commented Jul 7, 2020

License info is already showing on the home page, we might want to avoid adding duplicated info:

image

reyang
reyang reviewed Jul 7, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
reyang
reyang approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Welcome to this project @huyan0 😄

@huyan0
Copy link
Member Author

huyan0 commented Jul 7, 2020 •
edited
Loading

Thanks you! I changed the style of the badges and removed the heading "About this project" so that there is one less line break.

@reyang
Copy link
Member

reyang commented Jul 8, 2020

Please rebase and let's wait for a day for other folks to review and comment.

g-easy
g-easy reviewed Jul 8, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@huyan0 huyan0 marked this pull request as draft July 8, 2020 14:49
@huyan0 huyan0 marked this pull request as ready for review July 8, 2020 15:16
@reyang reyang merged commit 5bcf2d5 into open-telemetry:master Jul 8, 2020
@huyan0 huyan0 mentioned this pull request Jul 9, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-easy g-easy g-easy left review comments

@pyohannes pyohannes pyohannes approved these changes

@reyang reyang reyang approved these changes

@maxgolov maxgolov maxgolov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huyan0 @reyang @pyohannes @g-easy @maxgolov