Remove misleading comments about ABI compatibility for nostd::span #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
approved these changes
Nov 2, 2022
ThomsonTan
reviewed
Nov 2, 2022
| @@ -240,9 +240,6 @@ class span<T, dynamic_extent> | |||
| T *end() const noexcept { return data_ + extent_; } | |||
|
|
|||
| private: | |||
| // Note: matches libstdc++'s layout for std::span | |||
There was a problem hiding this comment.
But it seems the definition here does provide the ABI compatibility as libc++, do you mean this is unnecessary?
There was a problem hiding this comment.
It was compatible with one version of libc++ at one point, but the library implementation changed other time.
We can't guarantee ABI compatibility with a moving target, so we should not claim or hint it is compatible.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1731 +/- ##
==========================================
+ Coverage 85.77% 85.79% +0.02%
==========================================
Files 171 171
Lines 5212 5212
==========================================
+ Hits 4470 4471 +1
+ Misses 742 741 -1
|
owent
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1705
Changes
Remove misleading comments about ABI compatibility for nostd::span
CHANGELOG.mdupdated for non-trivial changes