[Metrics SDK] Cleanup ENABLE_METRICS_PREVIEW #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
==========================================
- Coverage 85.79% 85.73% -0.05%
==========================================
Files 171 171
Lines 5212 5212
==========================================
- Hits 4471 4468 -3
- Misses 741 744 +3
|
marcalff
approved these changes
Nov 6, 2022
sdk/CMakeLists.txt
Outdated
| if(NOT WITH_METRICS_PREVIEW) | ||
| set(METRICS_EXCLUDE_PATTERN "_metrics") | ||
| endif() | ||
| set(METRICS_EXCLUDE_PATTERN "_metrics") |
There was a problem hiding this comment.
Once _metrics are removed (PR #1734), METRICS_EXCLUDE_PATTERN can probably be removed as well.
lalitb
reviewed
Nov 6, 2022
api/CMakeLists.txt
Outdated
| if(NOT WITH_METRICS_PREVIEW) | ||
| set(METRICS_EXCLUDE_PATTERN "metrics") | ||
| endif() | ||
| set(METRICS_EXCLUDE_PATTERN "metrics") |
There was a problem hiding this comment.
we don't need this variable anymore.
lalitb
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This does cleanup as part of #1573 - remove ENABLE_METRICS_PREVIEW macro check in new metrics implementation.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes