[Metrics SDK] Change Prometheus CMake target name #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
changed the title
marcalff
requested changes
Nov 11, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1765 +/- ##
=======================================
Coverage 85.79% 85.79%
=======================================
Files 171 171
Lines 5212 5212
=======================================
Hits 4471 4471
Misses 741 741 |
|
I think we need to clean cache: can be done as explained here |
Thanks @esigo . |
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1764
Changed the target name to
opentelemetry_exporter_prometheus.$ ls /usr/local/lib/libopentelemetry_* -ltr -rw-r--r-- 1 root root 5884858 Oct 28 08:10 /usr/local/lib/libopentelemetry_proto.a -rw-r--r-- 1 root root 874006 Oct 28 16:19 /usr/local/lib/libopentelemetry_otlp_recordable.a -rw-r--r-- 1 root root 3300 Nov 10 16:11 /usr/local/lib/libopentelemetry_version.a -rw-r--r-- 1 root root 144904 Nov 10 16:11 /usr/local/lib/libopentelemetry_common.a -rw-r--r-- 1 root root 2794826 Nov 10 16:11 /usr/local/lib/libopentelemetry_resources.a -rw-r--r-- 1 root root 1910868 Nov 10 16:11 /usr/local/lib/libopentelemetry_http_client_curl.a -rw-r--r-- 1 root root 5777388 Nov 10 16:11 /usr/local/lib/libopentelemetry_trace.a -rw-r--r-- 1 root root 19873766 Nov 10 16:11 /usr/local/lib/libopentelemetry_metrics.a -rw-r--r-- 1 root root 1559820 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_ostream_metrics.a -rw-r--r-- 1 root root 2175672 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_prometheus.a -rw-r--r-- 1 root root 2887576 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_ostream_span.a -rw-r--r-- 1 root root 2444300 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_in_memory.a -rw-r--r-- 1 root root 411284 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc_client.a -rw-r--r-- 1 root root 2518 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc_log.a -rw-r--r-- 1 root root 1780364 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_http_client.a -rw-r--r-- 1 root root 941658 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_http_metric.a -rw-r--r-- 1 root root 1017242 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_http.a -rw-r--r-- 1 root root 1021982 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc_metrics.a -rw-r--r-- 1 root root 1093522 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc.a -rw-r--r-- 1 root root 4246512 Nov 10 16:29 /usr/local/lib/libopentelemetry_exporter_zipkin_trace.a