Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SEMANTIC CONVENTIONS] Upgrade to version 1.17.0 #1927

Merged
merged 3 commits into from
Jan 18, 2023
Merged

[SEMANTIC CONVENTIONS] Upgrade to version 1.17.0 #1927

merged 3 commits into from
Jan 18, 2023

Conversation

marcalff
Copy link
Member

Fixes #1915

Changes

Upgrade semantic convention to spec 1.17.0

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team January 17, 2023 22:18
lalitb
lalitb approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@codecov
Copy link

codecov bot commented Jan 17, 2023 •
edited
Loading

Codecov Report

Merging #1927 (0a8cda4) into main (59d0bc2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1927   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files         165      165           
  Lines        4594     4594           
=======================================
  Hits         3992     3992           
  Misses        602      602
Impacted Files Coverage Δ
...metrics/export/periodic_exporting_metric_reader.cc 74.08% <ø> (ø)
...include/opentelemetry/sdk/common/circular_buffer.h 98.00% <0.00%> (-2.00%) ⬇️
sdk/src/trace/batch_span_processor.cc 91.48% <0.00%> (+0.78%) ⬆️

@lalitb lalitb enabled auto-merge (squash) January 18, 2023 16:50
@lalitb lalitb merged commit 7406b4f into open-telemetry:main Jan 18, 2023
@marcalff marcalff deleted the fix_sem_conv_1915 branch July 4, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SEMANTIC CONVENTIONS] Upgrade to version 1.17.0
2 participants
@marcalff @lalitb