Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce copyright check in CI #1965

Merged
merged 8 commits into from
Feb 8, 2023
Merged

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Feb 7, 2023

Enforce copyright check in CI.

Changes

Added:

  • a Copyright check in CI,
  • a tools/check_copyright.sh script,
  • file .copyright-ignored to allow for copyright exceptions.

Checklist:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed (no changes)

@marcalff marcalff requested a review from a team February 7, 2023 12:21
@marcalff
Copy link
Member Author

marcalff commented Feb 7, 2023

With the initial commit, the Copyright CI fails, as expected, because all files do not have a proper copyright.

This is an opportunity to check the logs in the failed CI.

After PR #1963 is merged, the list of issues should shrink, and list only remaining items.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1965 (01fc8b1) into main (1d18614) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1965   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files         165      165           
  Lines        4596     4596           
=======================================
  Hits         4004     4004           
  Misses        592      592           
Impacted Files Coverage Δ
sdk/src/trace/samplers/trace_id_ratio.cc 100.00% <ø> (ø)

@marcalff
Copy link
Member Author

marcalff commented Feb 7, 2023

Ready for review.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. nicely done, thanks.

tools/check_copyright.sh Outdated Show resolved Hide resolved
.copyright-ignore Outdated Show resolved Hide resolved
.copyright-ignore Outdated Show resolved Hide resolved
@marcalff marcalff added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Feb 8, 2023
@lalitb lalitb merged commit 2544803 into open-telemetry:main Feb 8, 2023
@marcalff marcalff deleted the fix_ci_copyright branch July 4, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants