Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Fix if JSON library already added another CMake target #2126

Merged
merged 1 commit into from
May 3, 2023

Conversation

cngzhnp
Copy link
Contributor

@cngzhnp cngzhnp commented Apr 29, 2023

Fixes #1879

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #2126 (d83f01b) into main (2fd3d35) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2126   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         166      166           
  Lines        4784     4784           
=======================================
  Hits         4171     4171           
  Misses        613      613           

@cngzhnp cngzhnp marked this pull request as ready for review April 29, 2023 20:37
@cngzhnp cngzhnp requested a review from a team April 29, 2023 20:37
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

@ThomsonTan ThomsonTan merged commit 8c75041 into open-telemetry:main May 3, 2023
@marcalff marcalff changed the title Fix if JSON library already added another CMake target [BUILD] Fix if JSON library already added another CMake target May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nlohmann library can cause conflict on CMake targets during build
4 participants