Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Add OPENTELEMETRY_CPP_FOUND into cmake CONFIG file. #2215

Merged
merged 1 commit into from
Jul 5, 2023
Merged

[BUILD] Add OPENTELEMETRY_CPP_FOUND into cmake CONFIG file. #2215

merged 1 commit into from
Jul 5, 2023

Conversation

owent
Copy link
Member

@owent owent commented Jul 4, 2023

Fixes #2212

Changes

  • Add OPENTELEMETRY_CPP_FOUND in cmake CONFIG file.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team July 4, 2023 10:54
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #2215 (814396d) into main (ebbcd48) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2215   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files         169      169           
  Lines        4889     4889           
=======================================
  Hits         4279     4279           
  Misses        610      610

marcalff
marcalff approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

esigo
esigo approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks :)

@marcalff marcalff changed the title Add OPENTELEMETRY_CPP_FOUND into cmake CONFIG file. [BUILD] Add OPENTELEMETRY_CPP_FOUND into cmake CONFIG file. Jul 5, 2023
@marcalff marcalff merged commit 31f218c into open-telemetry:main Jul 5, 2023
42 checks passed
@owent owent deleted the fix_2212 branch July 13, 2023 06:25
@chenrui333 chenrui333 mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@marcalff marcalff marcalff approved these changes

@esigo esigo esigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@owent @ThomsonTan @marcalff @esigo