Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Deliver ABI breaking changes #2222

Merged
merged 15 commits into from
Sep 14, 2023
Merged

[API] Deliver ABI breaking changes #2222

merged 15 commits into from
Sep 14, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jul 7, 2023 •
edited
Loading

Fixes #1983

Changes

Adjust the makefiles to support multiple ABIs.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff changed the title Proof of concept. [POC] Deliver ABI breaking changes Jul 7, 2023
@marcalff marcalff mentioned this pull request Jul 7, 2023
Closed
@codecov
Copy link

codecov bot commented Jul 7, 2023 •
edited
Loading

Codecov Report

Merging #2222 (032033e) into main (f5f3934) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2222      +/-   ##
==========================================
- Coverage   87.53%   87.50%   -0.03%     
==========================================
  Files         199      199              
  Lines        5981     5981              
==========================================
- Hits         5235     5233       -2     
- Misses        746      748       +2

@marcalff marcalff mentioned this pull request Jul 7, 2023
Merged
3 tasks
@marcalff marcalff marked this pull request as ready for review July 10, 2023 20:52
@marcalff marcalff requested a review from a team July 10, 2023 20:52
@marcalff marcalff mentioned this pull request Aug 25, 2023
Open
@marcalff marcalff changed the title [POC] Deliver ABI breaking changes [API] Deliver ABI breaking changes Sep 5, 2023
@marcalff marcalff added the issue:blocking This issue is preventing other fixes label Sep 13, 2023
@marcalff
Copy link
Member Author

Blocking, prerequisite for:

lalitb
lalitb reviewed Sep 13, 2023
View reviewed changes
api/CMakeLists.txt Outdated Show resolved Hide resolved
docs/abi-version-policy.md Outdated Show resolved Hide resolved
@lalitb
Copy link
Member

lalitb commented Sep 13, 2023

Still looking into the PR. Will be completing it by tomorrow :)

lalitb
lalitb approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the work.

@marcalff marcalff merged commit b9776d6 into open-telemetry:main Sep 14, 2023
45 checks passed
@marcalff marcalff added abi:version_2 Fix is available WITH_ABI_VERSION_2 and removed issue:blocking This issue is preventing other fixes labels Sep 21, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 16, 2023
Merged
@marcalff marcalff deleted the fix_breaking_change_1983 branch October 27, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan left review comments

@lalitb lalitb lalitb approved these changes

@owent owent owent approved these changes

Assignees

@lalitb lalitb

@esigo esigo

Labels
abi:version_2 Fix is available WITH_ABI_VERSION_2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare release, include fixes with abi breaking changes
5 participants
@marcalff @lalitb @ThomsonTan @owent @esigo