Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile with clang 16 and libc++ #2242

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Fix compile with clang 16 and libc++ #2242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b356360
Fix compile with clang 16 and libc++
owent Jul 20, 2023
37f3dac
Merge branch 'main' into fix_compile_with_clang16_libcxx
owent Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/include/opentelemetry/sdk/logs/simple_log_record_processor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class SimpleLogRecordProcessor : public LogRecordProcessor

public:
explicit SimpleLogRecordProcessor(std::unique_ptr<LogRecordExporter> &&exporter);
~SimpleLogRecordProcessor() override = default;
~SimpleLogRecordProcessor() override;

std::unique_ptr<Recordable> MakeRecordable() noexcept override;

Expand Down
2 changes: 2 additions & 0 deletions sdk/src/logs/simple_log_record_processor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ SimpleLogRecordProcessor::SimpleLogRecordProcessor(std::unique_ptr<LogRecordExpo
: exporter_(std::move(exporter)), is_shutdown_(false)
{}

SimpleLogRecordProcessor::~SimpleLogRecordProcessor() {}

std::unique_ptr<Recordable> SimpleLogRecordProcessor::MakeRecordable() noexcept
{
return exporter_->MakeRecordable();
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/metrics/data/circular_buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ struct AdaptingIntegerArrayClear
template <typename T>
void operator()(std::vector<T> &backing)
{
std::fill(backing.begin(), backing.end(), static_cast<T>(0));
backing.assign(backing.size(), static_cast<T>(0));
}
};

Expand Down