added public link of opentelemetry_proto_grpc against [shared] gRPC lib
#2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y if gRPC library is shared]
|
Thanks. I think the fix is in-line with what we discussed here - #1940 (comment) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
==========================================
- Coverage 87.52% 87.50% -0.01%
==========================================
Files 199 199
Lines 5981 5981
==========================================
- Hits 5234 5233 -1
- Misses 747 748 +1 |
owent
approved these changes
Aug 17, 2023
lalitb
approved these changes
Aug 17, 2023
waywardmonkeys
added a commit
to waywardmonkeys/vcpkg
that referenced
this pull request
Jan 2, 2024
The patch to add a dependency of opentelemetry-proto on gRPC should not be needed after the upstream changes in: open-telemetry/opentelemetry-cpp#2268
waywardmonkeys
added a commit
to waywardmonkeys/vcpkg
that referenced
this pull request
Jan 2, 2024
The patch to add a dependency of opentelemetry-proto on gRPC should not be needed after the upstream changes in: open-telemetry/opentelemetry-cpp#2268 Additionally, the "zpages" feature is removed as it is no longer present upstream after having been deprecated in a previous release.
waywardmonkeys
added a commit
to waywardmonkeys/vcpkg
that referenced
this pull request
Jan 2, 2024
The patch to add a dependency of opentelemetry-proto on gRPC should not be needed after the upstream changes in: open-telemetry/opentelemetry-cpp#2268 Additionally, the "zpages" feature is removed as it is no longer present upstream after having been deprecated in a previous release. Fixes microsoft#35992.
7 tasks
waywardmonkeys
added a commit
to waywardmonkeys/vcpkg
that referenced
this pull request
Jan 4, 2024
The patch to add a dependency of opentelemetry-proto on gRPC should not be needed after the upstream changes in: open-telemetry/opentelemetry-cpp#2268 Additionally, the "zpages" feature is removed as it is no longer present upstream after having been deprecated in a previous release. A patch is added extracted from open-telemetry/opentelemetry-cpp#2475 which fixes problems that arose after `NOMINMAX` was no longer defined within opentelemetry-cpp on Windows. Fixes microsoft#35992.
waywardmonkeys
added a commit
to waywardmonkeys/vcpkg
that referenced
this pull request
Jan 4, 2024
The patch to add a dependency of opentelemetry-proto on gRPC should not be needed after the upstream changes in: open-telemetry/opentelemetry-cpp#2268 Additionally, the "zpages" feature is removed as it is no longer present upstream after having been deprecated in a previous release. A patch is added extracted from open-telemetry/opentelemetry-cpp#2475 and open-telemetry/opentelemetry-cpp#2449 which fix problems that arose after `NOMINMAX` was no longer defined within opentelemetry-cpp on Windows. Fixes microsoft#35992.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only if gRPC library is shared
Fixes #1891
Changes implemented as alternative to PR #1891 do not resolve issues with mac builds against shared gRPC library.
Furthermore, code generated by recent protobuf-grpc compiler contain references into gRPC library, hence
opentelemetry_proto_grpcshould be linked against gRPC library.Since it is believed that STATIC gRPC library should only be [privately] linked into a single library, I suppose there are no issues with linking SHARED gRPC library wherever it is needed.