Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMANTIC CONVENTION] Deprecated semconv (in the spec) not deprecated (in C++) #2285

Merged
merged 3 commits into from
Sep 2, 2023

Conversation

marcalff
Copy link
Member

Fixes #2275

Changes

When a semantic convention is flagged deprecated:

  • Add a doxygen @deprecated comment
  • Add OPENTELEMETRY_DEPRECATED in the generated C++ code.

Generated semantic conventions again.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team August 31, 2023 14:22
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #2285 (6a6ed51) into main (f52ec6c) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2285      +/-   ##
==========================================
- Coverage   87.52%   87.50%   -0.01%     
==========================================
  Files         199      199              
  Lines        5981     5981              
==========================================
- Hits         5234     5233       -1     
- Misses        747      748       +1     

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@marcalff marcalff merged commit 01e6581 into open-telemetry:main Sep 2, 2023
44 checks passed
@marcalff marcalff deleted the fix_deprecated_semconv_2275 branch September 5, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SEMANTIC CONVENTION] Deprecated semconv (in the spec) not deprecated (in C++)
3 participants