Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPORTER] Prometheus cleanup, test with TranslateToPrometheus #2329

Merged
merged 1 commit into from
Sep 25, 2023
Merged

[EXPORTER] Prometheus cleanup, test with TranslateToPrometheus #2329

merged 1 commit into from
Sep 25, 2023

Conversation

punya
Copy link
Member

@punya punya commented Sep 25, 2023

Instead, test using the TranslateToPrometheus public API.

@punya
[exporters/prometheus] Get rid of friend test
99bed27 
Instead, test using the TranslateToPrometheus public API.
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2329 (99bed27) into main (61e7429) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2329   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         199      199           
  Lines        5997     5997           
=======================================
  Hits         5244     5244           
  Misses        753      753

@punya punya marked this pull request as ready for review September 25, 2023 09:38
@punya punya requested a review from a team September 25, 2023 09:38
marcalff
marcalff approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the test cleanup.

@lalitb lalitb merged commit d49ba52 into open-telemetry:main Sep 25, 2023
45 checks passed
@marcalff marcalff changed the title [exporters/prometheus] Get rid of friend test [EXPORTER] Prometheus cleanup, test with TranslateToPrometheus Oct 11, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@punya @lalitb @marcalff