[Exporter] Group spans by resource and instrumentation scope in OTLP export requests #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2335 +/- ##
==========================================
+ Coverage 87.43% 87.45% +0.02%
==========================================
Files 199 199
Lines 5997 5997
==========================================
+ Hits 5243 5244 +1
+ Misses 754 753 -1 |
This reverts commit ed3e87e.
lalitb
approved these changes
Sep 28, 2023
| { | ||
| *scope_spans->add_spans() = std::move(input_span->span()); | ||
| } | ||
| } |
There was a problem hiding this comment.
nit - perhaps we can remove OtlpRecordable::ProtoResource(), OtlpRecordable::GetProtoInstrumentationScope() and OtlpRecordable::GetInstrumentationLibrarySchemaURL() methods now that they are not used to populate request object.
marcalff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation of
OtlpRecordableUtils::PopulateRequestto group spans by their resource and instrumentation scope.Instead of duplicating the resource and instrumentation scope for every span this now collects spans with the same resources and instrumentation scopes, reducing the size of the resulting
proto::collector::trace::v1::ExportTraceServiceRequest.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes