[BUILD] Fix opentracing-shim when added in super project #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2356 +/- ##
==========================================
- Coverage 87.41% 87.39% -0.01%
==========================================
Files 199 199
Lines 6018 6018
==========================================
- Hits 5260 5259 -1
- Misses 758 759 +1 |
andremarianiello
force-pushed
the
fix-opentracing-shim-cmake
branch
from
b0cd683
to
56a527b
Compare
andremarianiello
force-pushed
the
fix-opentracing-shim-cmake
branch
from
56a527b
to
d012e9b
Compare
lalitb
approved these changes
Oct 11, 2023
|
@owent Could you take a look ? CMake related |
ThomsonTan
approved these changes
Oct 11, 2023
marcalff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2355
Changes
Change the opentracing-shim include paths to be relative to opentelemetry-cpp directory, rather than the root cmake project directory. Those two directories will be different if opentelemetry-cpp is added to a larger project.
I also switched
include_directoriestotarget_include_directoriesas my understanding is that the latter is current best-practice. This necessitated gating the includes with a BUILD_INTERFACE generator expression. However, I don't think this change is required for this fix. I just wanted to improve it a little bit.