Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add InstrumentationScope attributes in TracerProvider::GetTracer() #2371

Merged
merged 4 commits into from
Oct 19, 2023
Merged

[API] Add InstrumentationScope attributes in TracerProvider::GetTracer() #2371

merged 4 commits into from
Oct 19, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Oct 16, 2023 •
edited
Loading

Fixes #2032

Changes

Please provide a brief description of the changes here.

API:

  • Implemented a new GetTracer() api with 4 parameters, only available in ABI VERSION 2
  • Renamed parameters to be consistent with the spec.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #2371 (a892095) into main (d9ad76f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2371      +/-   ##
==========================================
+ Coverage   87.43%   87.43%   +0.01%     
==========================================
  Files         199      199              
  Lines        6028     6030       +2     
==========================================
+ Hits         5270     5272       +2     
  Misses        758      758
Files Coverage Δ
api/include/opentelemetry/trace/noop.h 93.34% <100.00%> (ø)
api/include/opentelemetry/trace/tracer_provider.h 100.00% <ø> (ø)
sdk/src/trace/tracer_provider.cc 89.14% <100.00%> (+0.50%) ⬆️

@marcalff marcalff marked this pull request as ready for review October 18, 2023 21:06
@marcalff marcalff requested a review from a team October 18, 2023 21:06
@marcalff marcalff added the abi:version_2 Fix is available WITH_ABI_VERSION_2 label Oct 18, 2023
lalitb
lalitb approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Thanks.

@marcalff marcalff merged commit 91dd15f into open-telemetry:main Oct 19, 2023
45 checks passed
@marcalff marcalff deleted the fix_get_tracer_abiv2_2032 branch October 27, 2023 10:15
@marcalff marcalff mentioned this pull request Oct 29, 2023
Merged
5 tasks
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Oct 31, 2023
@marcalff
Update spec-compliance-matrix.md for C++ (#3747)
7a7b36e 
## Changes

Update spec-compliance-matrix.md for C++:

* `Get a Tracer with scope attributes` implemented by:
  * open-telemetry/opentelemetry-cpp#2371
* `Links can be recorded after span creation` implemented by:
  * open-telemetry/opentelemetry-cpp#2380
* `get_meter accepts attributes` implemented by:
  * open-telemetry/opentelemetry-cpp#2224
@Porkepix Porkepix mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
abi:version_2 Fix is available WITH_ABI_VERSION_2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Trace API/SDK] Add InstrumentationScope attributes in TracerProvider::GetTracer()
2 participants
@marcalff @lalitb