Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Make WITH_OTLP_HTTP_SSL_PREVIEW mainstream #2378

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Oct 18, 2023

Fixes #2365

Changes

Please provide a brief description of the changes here.

  • Promote option WITH_OTLP_HTTP_SSL_PREVIEW from experimental to stable
  • Promote option WITH_OTLP_HTTP_SSL_TLS_PREVIEW from experimental to stable
  • Change default for both to ON

After this change, SSL and TLS options will be included by default in the build.
It will still be possible to exclude the feature from the build, by setting options to OFF, only in release 1.13.0.

Future planned changes

Once this change is shipped as part of the next release (v1.13.0), a subsequent PR will remove the options entirely for release 1.14.0.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2378 (8dc908d) into main (231ca4a) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2378      +/-   ##
==========================================
- Coverage   87.43%   87.41%   -0.01%     
==========================================
  Files         199      199              
  Lines        6028     6028              
==========================================
- Hits         5270     5269       -1     
- Misses        758      759       +1     

see 1 file with indirect coverage changes

@marcalff marcalff marked this pull request as ready for review October 18, 2023 22:13
@marcalff marcalff requested a review from a team October 18, 2023 22:13
@marcalff marcalff merged commit 0e6eae0 into open-telemetry:main Oct 19, 2023
45 checks passed
@marcalff marcalff deleted the fix_ssl_mainstream_2365 branch October 27, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make WITH_OTLP_HTTP_SSL_PREVIEW mainstream
2 participants