Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Check windows options are not passed to non-Windows build #2399

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented Nov 10, 2023

Windows specific option like OPENTELEMETRY_BUILD_DLL can still be enabled for Linux build, while it failed the build much later buy reporting some DLL lib cannot be found. This PR prevents the confusion by failing the build early if these options are enabled on Linux.

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team November 10, 2023 05:09
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2399 (63d23d9) into main (6322607) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2399      +/-   ##
==========================================
+ Coverage   87.41%   87.43%   +0.02%     
==========================================
  Files         199      199              
  Lines        6028     6028              
==========================================
+ Hits         5269     5270       +1     
+ Misses        759      758       -1     

see 1 file with indirect coverage changes

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

@marcalff marcalff changed the title Check windows options are not passed to non-Windows build [BUILD] Check windows options are not passed to non-Windows build Nov 12, 2023
CMakeLists.txt Outdated Show resolved Hide resolved
@marcalff marcalff merged commit 5bd9c65 into open-telemetry:main Nov 12, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants