[BUILD] Better handling of OPENTELEMETRY_STL_VERSION under Bazel. #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2503 +/- ##
=======================================
Coverage ? 87.11%
=======================================
Files ? 200
Lines ? 6109
Branches ? 0
=======================================
Hits ? 5321
Misses ? 788
Partials ? 0 |
bcsgh
force-pushed
the
bcsgh/2470/with_cxx_stdlib
branch
from
28ff0d3
to
2d2939a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2470 for Bazel.
Changes
Make Bazel build, by default, use the "current" actual C++ version as
OPENTELEMETRY_STL_VERSION.Note that some compilers use some "interesting" values for
__cpluspluswhen asked to compiler for the most recent version they support. This can result in slightly unexpected results, but might actually be a good thing if those values indicate less than perfect support for the version in question and cause a downgrade to a better supported library.