[API] Propagators: do not overwrite the active span with a default invalid span #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecourreges-orange
force-pushed
the
fixCompositePropagator
branch
from
ae019ff
to
f9e6e95
Compare
ecourreges-orange
changed the title
|
Bonjour @ecourreges-orange Thanks for the PR, CI build in progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2511 +/- ##
==========================================
+ Coverage 87.08% 87.12% +0.05%
==========================================
Files 200 200
Lines 6103 6109 +6
==========================================
+ Hits 5314 5322 +8
+ Misses 789 787 -2
|
ecourreges-orange
force-pushed
the
fixCompositePropagator
branch
from
f1dde84
to
9ef1ed6
Compare
… active span with a default invalid span, which is especially useful when used with CompositePropagator (open-telemetry#2504) [TEST] Change wrong string "current-span" in unit tests to proper trace:kSpan which is "active_span"
ecourreges-orange
force-pushed
the
fixCompositePropagator
branch
from
9ef1ed6
to
5b7fa3c
Compare
You're welcome, happy to be contributing! |
marcalff
changed the title
marcalff
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[API] Fix b3, w3c and jaeger propagators: they will not overwrite the active span with a default invalid span
This is especially useful when used with CompositePropagator (#2504)
[TEST] Change wrong string "current-span" in unit tests to proper trace:kSpan which is "active_span"
Fixes #2504
Changes
This changes how Extract returns when invalid or missing headers are provided: it now returns the original context with potentially no active_span (or not overwritten if one was present).
But this should not have side effects on client code which calls GetSpan(context), which answers a default invalid span when it does not find an active_span
CHANGELOG.mdupdated for non-trivial changes