Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] Restore Recordable API compatibility with versions < 1.14.0 #2547

Merged
merged 6 commits into from
Feb 23, 2024
Merged

[SDK] Restore Recordable API compatibility with versions < 1.14.0 #2547

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cee8ec4
fix: Recordable backwards compat for versions < 1.14.0
dbolduc Feb 22, 2024
da5fbd8
suppress compiler warnings
dbolduc Feb 22, 2024
5df527a
d'oh
dbolduc Feb 22, 2024
1d1c3c0
Merge branch 'main' into recordable-back-compat
ThomsonTan Feb 23, 2024
5b56ce9
Merge branch 'main' into recordable-back-compat
marcalff Feb 23, 2024
d527650
Update sdk/include/opentelemetry/sdk/trace/recordable.h
marcalff Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/include/opentelemetry/sdk/trace/recordable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class Recordable
* Set the trace flags of the span.
* @param flags the flags to set
*/
virtual void SetTraceFlags(opentelemetry::trace::TraceFlags flags) noexcept = 0;
virtual void SetTraceFlags(opentelemetry::trace::TraceFlags /* flags */) noexcept {}

/**
* Set the spankind of the span.
Expand Down