Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Support for OTEL_SERVICE_NAME #2577

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

willie
Copy link
Contributor

@willie willie commented Mar 5, 2024

OTEL_SERVICE_NAME overrides OTEL_RESOURCE_ATTRIBUTES when it is defined.

Fixes #2559

Changes

Adds support for OTEL_SERVICE_NAME environmental variable to set "service.name".

OTEL_SERVICE_NAME overrides OTEL_RESOURCE_ATTRIBUTES when it is defined.
Copy link

linux-foundation-easycla bot commented Mar 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes.

@willie willie changed the title [WIP] support for OTEL_SERVICE_NAME support for OTEL_SERVICE_NAME Mar 5, 2024
@willie willie marked this pull request as ready for review March 5, 2024 20:30
@willie willie requested a review from a team March 5, 2024 20:30
@marcalff marcalff changed the title support for OTEL_SERVICE_NAME [SDK] Support for OTEL_SERVICE_NAME Mar 6, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

@marcalff marcalff merged commit 14f7542 into open-telemetry:main Mar 6, 2024
47 checks passed
bogdandrutu added a commit to open-telemetry/opentelemetry-specification that referenced this pull request Mar 8, 2024
Spec compliance matrix: Add OTEL_SERVICE_NAME to C++

## Changes

Please provide a brief description of the changes here.

For non-trivial changes, follow the [change proposal
process](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#proposing-a-change).

* [X] Related issues
open-telemetry/opentelemetry-cpp#2577
* [ ] Related [OTEP(s)](https://github.com/open-telemetry/oteps) #
* [ ] Links to the prototypes (when adding or changing features)
* [ ]
[`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md)
file updated for non-trivial changes
* [X]
[`spec-compliance-matrix.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md)
updated if necessary

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no support for OTEL_SERVICE_NAME
4 participants