Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix forceflush may wait for ever #2584
[SDK] Fix forceflush may wait for ever #2584
Changes from 19 commits
4f4a924
cc9db7b
8561e1f
5ca613f
bbb1f9a
e7031c2
e194608
6f12107
dbb6bb7
7444f31
7e0596c
ab39d6c
70d4a88
d5ca529
0b95c70
eea67c8
cd7c21b
1c21601
f28eab8
d3df9a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the fetch_add here just the same as
synchronization_data_->force_flush_pending_sequence++
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my understanding,
synchronization_data_->force_flush_pending_sequence++
usestd::memory_order_seq_cst
, we can usestd::memory_order_release
here.