Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMANTIC CONVENTIONS] Rework on semantic conventions 1.25.0 #2640

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Apr 17, 2024

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

This fix is a follow up on #2633.

Context:

When generating resource semantic conventions,
the code generation does not fail when a unknown reference to service.name is found,
which seems a bug for build tools, and the semantic convention opentelemetry::sdk::resource::SemanticConventions::kServiceName is not generated.

This causes a breaking change for instrumented applications.

Changes:

This fix changes the command used to generate resource semantic conventions,
to use resource,attribute_group instead of resource, so that attributes groups definitions are available
to the code generation.

When invoking the code generator with resource,attribute_group,
the symbol opentelemetry::sdk::resource::SemanticConventions::kServiceName is generated.

With this fix, instrumented application code is unchanged (previous changes using trace::SemanticConventions::kServiceName as a work around have been reverted)

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff marked this pull request as ready for review April 17, 2024 17:36
@marcalff marcalff requested a review from a team April 17, 2024 17:36
@marcalff marcalff added the pr:please-review This PR is ready for review label Apr 17, 2024
@marcalff marcalff changed the title Rework on semantic conventions 1.15.0 Rework on semantic conventions 1.25.0 Apr 17, 2024
@marcalff marcalff changed the title Rework on semantic conventions 1.25.0 [SEMANTIC CONVENTIONS] Rework on semantic conventions 1.25.0 Apr 17, 2024
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix

@marcalff marcalff merged commit 7aea1a6 into open-telemetry:main Apr 17, 2024
48 checks passed
@marcalff marcalff deleted the fix_semconv_regression branch June 3, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants