Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Link CoreFoundation on apple systems because some dependency packages require it #2655

Merged
merged 1 commit into from
May 6, 2024
Merged

[BUILD] Link CoreFoundation on apple systems because some dependency packages require it #2655

merged 1 commit into from
May 6, 2024

Conversation

owent
Copy link
Member

@owent owent commented May 6, 2024

Fixes #2649

Changes

  • Link CoreFoundation on apple systems

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team May 6, 2024 09:12
@marcalff marcalff changed the title Link CoreFoundation on apple systems because some dependency packages require it [BUILD] Link CoreFoundation on apple systems because some dependency packages require it May 6, 2024
marcalff
marcalff approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@marcalff marcalff merged commit da8e377 into open-telemetry:main May 6, 2024
48 checks passed
@malkia malkia mentioned this pull request May 6, 2024
Merged
3 tasks
@owent owent deleted the link_CoreFoundation_on_apple_systems branch May 23, 2024 02:32
@BrewTestBot BrewTestBot mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some symbols are missing when compiling to iOS
2 participants
@owent @marcalff