Add Prometheus Exporter: Step 2 - PrometheusCollector #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=======================================
Coverage 94.55% 94.55%
=======================================
Files 146 146
Lines 6610 6610
=======================================
Hits 6250 6250
Misses 360 360 |
…opentelemetry-cpp into prometheus_collector
reyang
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
I haven't actually got time to go through the change, given the internship is ending soon for @erichsueh3 and this change only touched Prometheus exporter (and a tiny bit on the CI job), based on offline discussion we'll move forward and get this merged for now.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the PrometheusCollector class and its header, source, test, and build files. This class is derived from the Collectable class in the C++ Prometheus client and allows for data translated from OpenTelemetry for Prometheus to be collected by an end user.
This PR is one in a series of PRs that aims to add a full implementation of a Prometheus Exporter within the OpenTelemetry C++ library.
Note to reviewers: Please keep in mind that this PR is dependent on the Prometheus Exporter Utils PRs(#280) so codecov tests may not fully pass.