-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXAMPLE] Clean the tracer initialization in OStream example #3051
[EXAMPLE] Clean the tracer initialization in OStream example #3051
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3051 +/- ##
==========================================
+ Coverage 87.12% 87.66% +0.55%
==========================================
Files 200 190 -10
Lines 6109 5866 -243
==========================================
- Hits 5322 5142 -180
+ Misses 787 724 -63 |
What is this change for - better naming for variables ? Can we ensure it is consistent across other examples, e.g. logs_simple also follow existing naming. |
Yes, mostly about naming. Applied the same change to logs_example. Will look other examples later. |
[EXAMPLE] Clean the tracer initialization in OStream example (open-telemetry#3051)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes