[EXPORTER] Add logging for async gRPC errors #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3108 +/- ##
==========================================
+ Coverage 87.12% 87.91% +0.79%
==========================================
Files 200 195 -5
Lines 6109 6133 +24
==========================================
+ Hits 5322 5391 +69
+ Misses 787 742 -45 |
marcalff
approved these changes
Oct 23, 2024
lalitb
reviewed
Oct 23, 2024
| OTEL_INTERNAL_LOG_ERROR("[OTLP GRPC Client] ERROR: Export " | ||
| << export_data_name << " failed with status_code: \"" | ||
| << grpc_status.error_code() << "\" error_message: \"" | ||
| << grpc_status.error_message() << "\""); |
There was a problem hiding this comment.
Not related to this PR, but we need to figure out some way of throttling, as this can otherwise flood the logs for the non-recoverable issues.
lalitb
approved these changes
Oct 23, 2024
marcalff
reviewed
Oct 24, 2024
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Oct 24, 2024
[EXPORTER] Add logging for async gRPC errors (open-telemetry#3108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If there's a gRPC error when exporting telemetry data via
gRPCwithENABLE_ASYNC_EXPORTset, this error is not printed via logs in the same way as it's done when exporting the data synchronously. Print the error stored ingrpc::Statusin the same way.