[BUILD] Patches for building on AIX #3127

tjcw · 2024-11-06T10:19:25Z

Fixes #3126

Changes

Build scripts and code tweaks to enable build on AIX

For significant contributions please make sure you have completed the following items:

CHANGELOG.md updated for non-trivial changes
Unit tests have been added
Changes in public API reviewed

linux-foundation-easycla · 2024-11-06T10:19:29Z

The committers listed above are authorized under a signed CLA.

✅ login: tjcw / name: Chris Ward (01e5bcf, 7510860, e477abb, 5045713, ae421a9, 8367bf8, 4c908f7)
✅ login: lalitb / name: Lalit Kumar Bhasin (662d794)

netlify · 2024-11-06T10:19:41Z

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name	Link
🔨 Latest commit	`4c908f7`
🔍 Latest deploy log	https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6731c42c6011c400087d1912

codecov · 2024-11-06T13:47:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (497eaf4) to head (4c908f7).
Report is 161 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3127      +/-   ##
==========================================
+ Coverage   87.12%   87.83%   +0.71%     
==========================================
  Files         200      195       -5     
  Lines        6109     6136      +27     
==========================================
+ Hits         5322     5389      +67     
+ Misses        787      747      -40

see 100 files with indirect coverage changes

cmake/tools.cmake

tjcw · 2024-11-06T17:38:41Z

No, one is ALIAS and the other is ALIASED

________________________________ From: Lalit Kumar Bhasin ***@***.***> Sent: Wednesday, November 6, 2024 5:36 PM To: open-telemetry/opentelemetry-cpp ***@***.***> Cc: Chris Ward ***@***.***>; Mention ***@***.***> Subject: [EXTERNAL] Re: [open-telemetry/opentelemetry-cpp] Patches for building on AIX (PR #3127) @ lalitb commented on this pull request. In cmake/tools. cmake: > @@ -160,6 +160,10 @@ function(project_build_tools_patch_default_imported_config) if(IS_ALIAS_TARGET) continue() endif() + get_target_property(IS_ALIASED_TARGET ${TARGET_NAME} @lalitb commented on this pull request.

________________________________ In cmake/tools.cmake<#3127 (comment)>:

@@ -160,6 +160,10 @@ function(project_build_tools_patch_default_imported_config)

if(IS_ALIAS_TARGET) continue() endif() + get_target_property(IS_ALIASED_TARGET ${TARGET_NAME} ALIASED_TARGET) + if (IS_ALIASED_TARGET) + continue() + endif() This if condition appears redundant, as it checks the same ALIASED_TARGET property again — Reply to this email directly, view it on GitHub<#3127 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC5CNDOZ25LKHC3UX5JAB3DZ7JHR5AVCNFSM6AAAAABRIPLQZSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJZGAYTGNRUGI>. You are receiving this because you were mentioned.Message ID: ***@***.***> Unless otherwise stated above: IBM United Kingdom Limited Registered in England and Wales with number 741598 Registered office: Building C, IBM Hursley Office, Hursley Park Road, Winchester, Hampshire SO21 2JN

sdk/include/opentelemetry/sdk/resource/semantic_conventions.h

tjcw · 2024-11-06T20:50:57Z

Is the CI failure something that I have caused ? Can someone tell me more about what is broken, and give me a test case to reproduce the fault?

lalitb · 2024-11-06T22:23:14Z

Is the CI failure something that I have caused ? Can someone tell me more about what is broken, and give me a test case to reproduce the fault?

@tjcw The CI failure is for the easyCLA you need to sign:

The PR can be merged only after that, and once all comments are resolved.

tjcw · 2024-11-06T22:28:57Z

OK. I am currently waiting for the person I think is IBM's CLA coordinator to turn round the email.
I have management permission to make this contribution and I will sign any reasonable CLA so I am sure all will be well in due course.

tjcw · 2024-11-09T04:47:48Z

I just got notified of a CI failure with this. It looks to me like a configuration or permission failure rather than a problem with my code. Can someone check please?

marcalff · 2024-11-09T10:27:19Z

I just got notified of a CI failure with this. It looks to me like a configuration or permission failure rather than a problem with my code. Can someone check please?

The following build failed in CI:

CMake test (build shared libraries with otlp-exporter and static gRPC)

This looks unrelated, restarting this build.

[edit]

Somehow, this test fails and spins forever:
Start 44: exporter.otlp.OtlpGrpcExporterFactoryTest.BuildTest

marcalff · 2024-11-09T16:10:32Z

sdk/include/opentelemetry/sdk/resource/semantic_conventions.h

+ * Special considerations for HostArchValues
+ *
+ * The sys/systemcfg.h header on AIX is known to define an IA64 macro,
+ * which collides with HostArchValues::IA64.


This work around is no longer necessary, after:

[SEMANTIC CONVENTIONS] Upgrade to version 1.15.0 #1761

Change naming to use camel case, to avoid collisions with macros.

I will change the PR to withdraw this workaround

tjcw · 2024-11-09T17:02:55Z

Does my PR make this test loop forever, or does this occur without my PR ?
If my PR causes it, please can you provide the test case or a description of what it does so I can reproduce the problem. You can email the test case to me as tjcw@uk.ibm.com

marcalff · 2024-11-09T17:53:29Z

Does my PR make this test loop forever, or does this occur without my PR ? If my PR causes it, please can you provide the test case or a description of what it does so I can reproduce the problem. You can email the test case to me as tjcw@uk.ibm.com

This is much likely an issue in the github worker itself, this happens some times (the github runner was upgraded lately).

I will investigate it separately.

[edit]

The only change in this area that can affect grpc is file cmale/opentelemetry-proto.cmake,
but not sure if/how it can cause issues if this is the root cause.

…ests to go into a loop

tjcw · 2024-11-11T08:47:58Z

I have backed out the change to cmake/opentelemetry-proto.cmake ; I can try applying it as a separate PR if necessary.

marcalff

LGTM, thanks for the contribution

[BUILD] Patches for building on AIX (open-telemetry#3127)

Patches for building on AIX

7510860

tjcw requested a review from a team as a code owner November 6, 2024 10:19

Merge branch 'open-telemetry:main' into main

8367bf8

marcalff added the pr:waiting-on-cla Waiting on CLA label Nov 6, 2024

lalitb reviewed Nov 6, 2024

View reviewed changes

cmake/tools.cmake Outdated Show resolved Hide resolved

Merge branch 'main' into main

662d794

ThomsonTan reviewed Nov 6, 2024

View reviewed changes

sdk/include/opentelemetry/sdk/resource/semantic_conventions.h Outdated Show resolved Hide resolved

tjcw and others added 2 commits November 7, 2024 14:17

Remove duplicated action on alias target

e477abb

Merge branch 'open-telemetry:main' into main

01e5bcf

marcalff reviewed Nov 9, 2024

View reviewed changes

tjcw and others added 3 commits November 10, 2024 06:32

Merge branch 'open-telemetry:main' into main

ae421a9

Withdraw undef of IA64 as already fixed by CNCF

5045713

Back out change to cmake/opentelemetry-proto.cmake as it caused the t…

4c908f7

…ests to go into a loop

tjcw mentioned this pull request Nov 11, 2024

Set up for opentelemetry_proto_grpc_lib_type being shared #3136

Closed

3 tasks

lalitb approved these changes Nov 11, 2024

View reviewed changes

lalitb removed the pr:waiting-on-cla Waiting on CLA label Nov 11, 2024

marcalff approved these changes Nov 12, 2024

View reviewed changes

marcalff changed the title ~~Patches for building on AIX~~ [BUILD] Patches for building on AIX Nov 12, 2024

marcalff merged commit a713947 into open-telemetry:main Nov 12, 2024
56 checks passed

malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Nov 12, 2024

Merge pull request #87 from open-telemetry/main

539d27e

[BUILD] Patches for building on AIX (open-telemetry#3127)

BrewTestBot mentioned this pull request Nov 26, 2024

opentelemetry-cpp 1.18.0 Homebrew/homebrew-core#199015

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUILD] Patches for building on AIX #3127

[BUILD] Patches for building on AIX #3127

tjcw commented Nov 6, 2024

linux-foundation-easycla bot commented Nov 6, 2024 •

edited

Loading

netlify bot commented Nov 6, 2024 •

edited

Loading

codecov bot commented Nov 6, 2024 •

edited

Loading

tjcw commented Nov 6, 2024 via email

tjcw commented Nov 6, 2024

lalitb commented Nov 6, 2024

tjcw commented Nov 6, 2024

tjcw commented Nov 9, 2024

marcalff commented Nov 9, 2024 •

edited

Loading

marcalff Nov 9, 2024

tjcw Nov 9, 2024

tjcw commented Nov 9, 2024

marcalff commented Nov 9, 2024 •

edited

Loading

tjcw commented Nov 11, 2024

marcalff left a comment

[BUILD] Patches for building on AIX #3127

[BUILD] Patches for building on AIX #3127

Conversation

tjcw commented Nov 6, 2024

Changes

linux-foundation-easycla bot commented Nov 6, 2024 • edited Loading

netlify bot commented Nov 6, 2024 • edited Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

codecov bot commented Nov 6, 2024 • edited Loading

Codecov Report

tjcw commented Nov 6, 2024 via email

tjcw commented Nov 6, 2024

lalitb commented Nov 6, 2024

tjcw commented Nov 6, 2024

tjcw commented Nov 9, 2024

marcalff commented Nov 9, 2024 • edited Loading

marcalff Nov 9, 2024

Choose a reason for hiding this comment

tjcw Nov 9, 2024

Choose a reason for hiding this comment

tjcw commented Nov 9, 2024

marcalff commented Nov 9, 2024 • edited Loading

tjcw commented Nov 11, 2024

marcalff left a comment

Choose a reason for hiding this comment

linux-foundation-easycla bot commented Nov 6, 2024 •

edited

Loading

netlify bot commented Nov 6, 2024 •

edited

Loading

codecov bot commented Nov 6, 2024 •

edited

Loading

marcalff commented Nov 9, 2024 •

edited

Loading

marcalff commented Nov 9, 2024 •

edited

Loading