Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Rename w3c_tracecontext_test to w3c_tracecontext_http_test_server #3132

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Nov 6, 2024

This rename was requested in PR #3115 to make it more clear that the test artifact being built under ext for w3c trace context compliance is actually a test server.

See this comment requesting this change.

Changes

  • Renames the ext/w3c_tracecontext_test directory to ext/w3c_tracecontext_test_server.
  • Updates the CI running W3C Trace Context Validation tests to accommodate this rename.

The CMake option has been kept as-is: BUILD_W3CTRACECONTEXT_TEST.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit ee5e9b9
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/672e47958139a200087ca185

@psx95 psx95 changed the title Rename w3c tracecontext [BUILD] Rename w3c_tracecontext_test to w3c_tracecontext_test_server Nov 6, 2024
@psx95 psx95 marked this pull request as ready for review November 6, 2024 22:03
@psx95 psx95 requested a review from a team as a code owner November 6, 2024 22:03
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (497eaf4) to head (ee5e9b9).
Report is 160 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
+ Coverage   87.12%   87.83%   +0.71%     
==========================================
  Files         200      195       -5     
  Lines        6109     6136      +27     
==========================================
+ Hits         5322     5389      +67     
+ Misses        787      747      -40     

see 100 files with indirect coverage changes

@psx95 psx95 mentioned this pull request Nov 7, 2024
17 tasks
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

with renaming to w3c_tracecontext_http_test_server per @lalitb suggestion.

@marcalff marcalff changed the title [BUILD] Rename w3c_tracecontext_test to w3c_tracecontext_test_server [TEST] Rename w3c_tracecontext_test to w3c_tracecontext_test_server Nov 7, 2024
@psx95 psx95 changed the title [TEST] Rename w3c_tracecontext_test to w3c_tracecontext_test_server [TEST] Rename w3c_tracecontext_test to w3c_tracecontext_http_test_server Nov 8, 2024
@marcalff marcalff added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Nov 8, 2024
@marcalff marcalff merged commit 1863fe7 into open-telemetry:main Nov 8, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants