-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Rename w3c_tracecontext_test to w3c_tracecontext_http_test_server #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
psx95
changed the title
Rename w3c tracecontext
[BUILD] Rename w3c_tracecontext_test to w3c_tracecontext_test_server
Nov 6, 2024
lalitb
reviewed
Nov 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3132 +/- ##
==========================================
+ Coverage 87.12% 87.83% +0.71%
==========================================
Files 200 195 -5
Lines 6109 6136 +27
==========================================
+ Hits 5322 5389 +67
+ Misses 787 747 -40 |
17 tasks
marcalff
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
with renaming to w3c_tracecontext_http_test_server
per @lalitb suggestion.
marcalff
changed the title
[BUILD] Rename w3c_tracecontext_test to w3c_tracecontext_test_server
[TEST] Rename w3c_tracecontext_test to w3c_tracecontext_test_server
Nov 7, 2024
lalitb
approved these changes
Nov 7, 2024
ThomsonTan
approved these changes
Nov 7, 2024
psx95
changed the title
[TEST] Rename w3c_tracecontext_test to w3c_tracecontext_test_server
[TEST] Rename w3c_tracecontext_test to w3c_tracecontext_http_test_server
Nov 8, 2024
marcalff
added
the
ok-to-merge
The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
label
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ok-to-merge
The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rename was requested in PR #3115 to make it more clear that the
test
artifact being built underext
for w3c trace context compliance is actually a test server.See this comment requesting this change.
Changes
ext/w3c_tracecontext_test
directory toext/w3c_tracecontext_test_server
.The CMake option has been kept as-is:
BUILD_W3CTRACECONTEXT_TEST
.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes