Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add cppcheck in the build #3151

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Conversation

chusitoo
Copy link
Contributor

@chusitoo chusitoo commented Nov 18, 2024

Fixes #2297

Changes

  • Added CI job for cppcheck. For now, it does not fail the build

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit a19d070
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/673bd648072f580008f43277

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (1695253) to head (a19d070).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3151   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files         195      195           
  Lines        6146     6146           
=======================================
  Hits         5398     5398           
  Misses        748      748           
---- 🚨 Try these New Features:

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the CI.

@chusitoo chusitoo marked this pull request as ready for review November 18, 2024 23:26
@chusitoo chusitoo requested a review from a team as a code owner November 18, 2024 23:26
@ThomsonTan
Copy link
Contributor

Is this a subset of the part 2 change?

@marcalff
Copy link
Member

marcalff commented Nov 19, 2024

Is this a subset of the part 2 change?

Yes.

Once part 1 is merged to main, part 2 PR will only contain part 2 (the code fixes).

@marcalff marcalff changed the title [CI] Add cppcheck in the build - part 1 [CI] Add cppcheck in the build Nov 19, 2024
@marcalff marcalff merged commit 8691248 into open-telemetry:main Nov 19, 2024
57 checks passed
@chusitoo chusitoo deleted the cppcheck_ci branch November 22, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Add a C++ static code analyser in the build
3 participants