Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Update opentelemetry-proto in MODULE.bazel #3163

Conversation

keith
Copy link
Contributor

@keith keith commented Nov 22, 2024

Mirrors fe68d51

@keith keith requested a review from a team as a code owner November 22, 2024 23:09
@keith
Copy link
Contributor Author

keith commented Nov 22, 2024

ci will fail until bazelbuild/bazel-central-registry#3245 is merged

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 04e6678
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6744cb3cfb40bd0008c15580

@marcalff
Copy link
Member

Thanks @keith

Waiting on bazel central PR first then.

@marcalff marcalff added the issue:blocked Fix blocked, waiting for other fixes as prerequisites label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (31956f8) to head (04e6678).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3163   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         195      195           
  Lines        6151     6151           
=======================================
  Hits         5404     5404           
  Misses        747      747           

@marcalff marcalff added the pr:do-not-merge This PR is not ready to be merged. label Nov 23, 2024
@keith keith force-pushed the ks/bazel-update-opentelemetry-proto-in-module.bazel branch from dfaff0b to 04e6678 Compare November 25, 2024 19:08
@keith
Copy link
Contributor Author

keith commented Nov 25, 2024

upstream landed, rebasing

@marcalff marcalff removed pr:do-not-merge This PR is not ready to be merged. issue:blocked Fix blocked, waiting for other fixes as prerequisites labels Nov 25, 2024
@marcalff marcalff merged commit 2a8c8bc into open-telemetry:main Nov 25, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants