Intialize default Zipkin endpoint from env var if exists #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #624 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 197 197
Lines 9131 9131
=======================================
Hits 8629 8629
Misses 502 502 |
lalitb
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #623
Changes
Get default Zipkin endpoint from environment variable
OTEL_EXPORTER_ZIPKIN_ENDPOINTif it is set.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes