Adding baggage implementation #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #676 +/- ##
==========================================
+ Coverage 94.66% 94.76% +0.10%
==========================================
Files 208 210 +2
Lines 9407 9644 +237
==========================================
+ Hits 8905 9139 +234
- Misses 502 505 +3
|
nikhil1511
changed the title
3 tasks
nikhil1511
changed the title
lalitb
reviewed
Apr 20, 2021
| } | ||
| header_s.append(Encode(key)); | ||
| header_s.push_back(kKeyValueSeparator); | ||
| header_s.append(Encode(value)); |
There was a problem hiding this comment.
Should we ensure not to encode metadata, as it may result in double encoding ( as we don't decode it in FromHeader() )
There was a problem hiding this comment.
Yes, you are correct. Will fix this issue. Missed this bug in testcases !
Update : fixed it
lalitb
reviewed
Apr 20, 2021
ThomsonTan
reviewed
Apr 20, 2021
ThomsonTan
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes