Set Spankind for Zipkin exporter #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #708 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 214 214
Lines 9750 9750
=======================================
Hits 9244 9244
Misses 506 506 |
ThomsonTan
approved these changes
Apr 28, 2021
exporters/zipkin/src/recordable.cc
Outdated
| { | ||
| if (kSpanKindMap.find(span_kind) != kSpanKindMap.end()) | ||
| { | ||
| span_["kind"] = kSpanKindMap.at(span_kind); |
There was a problem hiding this comment.
nit: save the find() result to a variable to avoid search the map twice?
maxgolov
reviewed
Apr 28, 2021
maxgolov
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Small fix to populate spankind attribute for Zipkin exporter.
specs : https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md#spankind
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes