Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #826 #827

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Fixes #826 #827

merged 1 commit into from
Jun 7, 2021

Conversation

owent
Copy link
Member

@owent owent commented Jun 5, 2021

Signed-off-by: owent admin@owent.net

Fixes #826

Changes

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team June 5, 2021 06:35
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #827 (1a5eb9b) into main (93dd39b) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
- Coverage   95.52%   95.50%   -0.01%     
==========================================
  Files         156      156              
  Lines        6618     6619       +1     
==========================================
  Hits         6321     6321              
- Misses        297      298       +1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.67% <0.00%> (-1.10%) ⬇️

@lalitb
Copy link
Member

lalitb commented Jun 7, 2021

@owent - Thanks for the fix. could you please rebase in order to get it merged.

Signed-off-by: owent <admin@owent.net>
@owent
Copy link
Member Author

owent commented Jun 7, 2021

@owent - Thanks for the fix. could you please rebase in order to get it merged.

Done.

@lalitb lalitb merged commit 12946c8 into open-telemetry:main Jun 7, 2021
@owent owent deleted the fix_826 branch June 8, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BatchSpanProcessor wakeup too frequently when no more data to export after a long time Export(...).
3 participants