Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protobuf compilation warning in gRPC example #830

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

ThomsonTan
Copy link
Contributor

Fixes #829

Changes

Port and apply the compilation options patch for opentelemetry-cpp to gRPC examples as well.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team June 7, 2021 17:29
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #830 (c8922e9) into main (12946c8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #830   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         156      156           
  Lines        6619     6619           
=======================================
  Hits         6321     6321           
  Misses        298      298           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix.

@lalitb lalitb merged commit 01837f5 into open-telemetry:main Jun 8, 2021
@ThomsonTan ThomsonTan deleted the FixGRPCWarning branch June 15, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build waring introduced by gRPC example
3 participants