Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix for Stack::Resize that new_capacity is not assigned to capacity_ #934

Merged
merged 3 commits into from
Aug 3, 2021
Merged

🐛 Fix for Stack::Resize that new_capacity is not assigned to capacity_ #934

merged 3 commits into from
Aug 3, 2021

Conversation

Yerannnnnn
Copy link
Contributor

Changes

Fix for Stack::Resize that new_capacity is not assigned to capacity_ , caused stack to constantly allocate memory when size_>0.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@Yerannnnnn Yerannnnnn requested a review from a team August 2, 2021 09:32
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 2, 2021

CLA Signed

The committers are authorized under a signed CLA.

@Yerannnnnn
Copy link
Contributor Author

Yerannnnnn commented Aug 2, 2021

CLA Signed

The committers are authorized under a signed CLA.

@lalitb
Copy link
Member

lalitb commented Aug 2, 2021

is not authorized under a signed CLA. Please click here to be authorized. 

I cliecked it then got {"message": "Internal server error"}

something wrong?

Yes, there is a problem with easyCLA validation: open-telemetry/community#795
Will merge this PR once it's solved. Thanks for the fix.

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #934 (f13163d) into main (d6c187c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
+ Coverage   95.36%   95.36%   +0.01%     
==========================================
  Files         160      160              
  Lines        6779     6780       +1     
==========================================
+ Hits         6464     6465       +1     
  Misses        315      315              
Impacted Files Coverage Δ
...pi/include/opentelemetry/context/runtime_context.h 97.50% <100.00%> (+0.04%) ⬆️

@lalitb
Copy link
Member

lalitb commented Aug 2, 2021

@Yerannnnnn - Can you try to authorize yourself for easyCLA now?

@Yerannnnnn
Copy link
Contributor Author

@Yerannnnnn - Can you try to authorize yourself for easyCLA now?

@lalitb Done

@lalitb lalitb merged commit 3a3bf25 into open-telemetry:main Aug 3, 2021
@Yerannnnnn Yerannnnnn deleted the fix_stack_resize_cap branch August 3, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants