-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to PR #86 Add minimal tracer example #94
Merged
reyang
merged 12 commits into
open-telemetry:master
from
ankit-bhargava:simple-trace-example
Jun 19, 2020
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1ef8430
Add a simple example for the tracer workflow
4d94891
Remove obsolete file
f61ae52
PR comments
3065c6b
Bazel fixes
d78bf3e
Fix bazel build
f2181b9
Adding documentation and build instructions
ankit-bhargava 52424b3
Condensed comments, moved build/run instructions to CONTRIBUTING.md
ankit-bhargava 5512d5f
Typo fix in README.md
ankit-bhargava 72f9c18
Updating comments in main.cc
ankit-bhargava 7c32c86
Incorporating review suggestions
ankit-bhargava 6ae95bb
spacing consistency and line wrapping
ankit-bhargava e89e017
rebased and removed leading spaces
ankit-bhargava File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
|
||
# Simple Trace Example | ||
|
||
In this example, the application in `main.cc` initializes and registers a tracer | ||
provider from the [OpenTelemetry SDK](https://github.com/open-telemetry/opentelemetry-cpp). | ||
The application then calls a `foo_library` which has been instrumented using | ||
the [OpenTelemetry API](https://github.com/open-telemetry/opentelemetry-cpp/tree/master/api). | ||
Resulting telemetry is directed to stdout through a custom exporter. | ||
|
||
See [CONTRIBUTING.md](../../CONTRIBUTING.md) for instructions on building and running the example. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be more sparse with inline comments and only use them to hint at things that cannot be inferred from the code itself. Otherwise they tend to make code harder to read instead of making it easier. There's no information in
that cannot be inferred from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminded me on one thing that I learned long time ago - make the code talk by itself.