Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bazel build for gcc 4.8, upgrade versions for grpc and bazel, document bazel support #953

Merged
merged 13 commits into from
Aug 19, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Aug 18, 2021

Fixes #947

Changes

  • Disable bazel build for gcc4.8, and this allows us to upgrade grpc and bazel versions used for the bazel build
  • Document build type supported for all platforms in README.md
  • Document Bazel build as experimental ( till it is supported for all the components) in INSTALL.md
  • macOS build is failing with the latest bazel version, have added a temporary fix for that for now.

New versions:
grpc : 1.39.1
Bazel: 4.2.0
Bazelisk: 1.10.1

cc @jsuereth

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team August 18, 2021 19:56
@lalitb lalitb changed the title Disable bazel build for gcc 4.8, upgrade versions for grpc, and bazel, document bazel support Disable bazel build for gcc 4.8, upgrade versions for grpc and bazel, document bazel support Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #953 (4d04d7a) into main (5e4962d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #953   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         160      160           
  Lines        6780     6780           
=======================================
  Hits         6465     6465           
  Misses        315      315           

run: ./ci/do_ci.sh bazel.legacy.test
env:
CC: /usr/bin/gcc-4.8
# bazel build is disabled for gcc 4.8 compiler as grpc lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say just remove this instead of comment. It's unlikely we can bring it back and of we need it it's in git history.

INSTALL.md Show resolved Hide resolved
@ThomsonTan ThomsonTan merged commit 205a3dd into open-telemetry:main Aug 19, 2021
@lalitb lalitb mentioned this pull request Sep 17, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearly denote Build Tool support in doocumentation.
3 participants