Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused public API to_span_ptr #964

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

ThomsonTan
Copy link
Contributor

TC review #946 mentioned to_span_ptr should not be public, remove it as it is not used.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team August 26, 2021 23:19
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #964 (c154562) into main (d210807) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         160      160           
  Lines        6780     6780           
=======================================
  Hits         6465     6465           
  Misses        315      315           
Impacted Files Coverage Δ
api/include/opentelemetry/trace/span.h 100.00% <ø> (ø)

@lalitb lalitb merged commit c7d6409 into open-telemetry:main Aug 27, 2021
@jsuereth jsuereth mentioned this pull request Sep 7, 2021
13 tasks
@lalitb lalitb mentioned this pull request Sep 17, 2021
3 tasks
@ThomsonTan ThomsonTan deleted the Remove_to_span_ptr branch September 22, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants