Skip to content

Commit

Permalink
Remove setting HTTP_ROUTE attribute in frontend (#566)
Browse files Browse the repository at this point in the history
As per the OpenTelemetry HTTP Server semantic conventions, `HTTP.ROUTE`
is meant to be a low cardinality route template. The URI cannot
substitute it.

This patch remove the usage of the HTTP_ROUTE semantic attribute.
  • Loading branch information
AbhiPrasad authored Nov 11, 2022
1 parent 16576de commit 978d193
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion docs/services/frontend.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ application context.
"app.synthetic_request": true,
[SemanticAttributes.HTTP_TARGET]: target,
[SemanticAttributes.HTTP_STATUS_CODE]: response.statusCode,
[SemanticAttributes.HTTP_ROUTE]: url,
[SemanticAttributes.HTTP_METHOD]: method,
[SemanticAttributes.HTTP_USER_AGENT]: headers['user-agent'] || '',
[SemanticAttributes.HTTP_URL]: `${headers.host}${url}`,
Expand Down
1 change: 0 additions & 1 deletion src/frontend/utils/telemetry/InstrumentationMiddleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const InstrumentationMiddleware = (handler: NextApiHandler): NextApiHandler => {
"app.synthetic_request": true,
[SemanticAttributes.HTTP_TARGET]: target,
[SemanticAttributes.HTTP_STATUS_CODE]: response.statusCode,
[SemanticAttributes.HTTP_ROUTE]: url,
[SemanticAttributes.HTTP_METHOD]: method,
[SemanticAttributes.HTTP_USER_AGENT]: headers['user-agent'] || '',
[SemanticAttributes.HTTP_URL]: `${headers.host}${url}`,
Expand Down

0 comments on commit 978d193

Please sign in to comment.